Tidy up users endpoint #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pbochis
commented
Oct 8, 2015
pbochis
commented
- GET /users now returns all the users, as expected
- add GET /invitations which will return all users invited by a company
Contributor
Author
|
If this will be merged, please also merge (this)[https://github.com/coduno/app/pull/119] otherwise app will break. |
controllers/user.go
Outdated
Contributor
There was a problem hiding this comment.
else is not needed, as the if above will return.
pbochis
force-pushed
the
refactor-user-endpoint
branch
2 times, most recently
from
64affaf to
9606ee5
Compare
* GET /users now returns all the users, as expected * add GET /invitations which will return all users invited by a company
pbochis
force-pushed
the
refactor-user-endpoint
branch
from
9606ee5 to
bc1f9f7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.